Various Followups to 2039 and 2674 #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user declines to specify a `max_total_routing_fee_msat` in the new BOLT12 payment methods, rather than defaulting to no limit on the fee we pay at all, we should default to our "usual default", ie the one calculated in `RouteParameters::from_payment_params_and_value`. We do this here, as well as documenting the behavior on the payment methods.
wpaulino
previously approved these changes
Oct 20, 2023
benthecarman
approved these changes
Oct 20, 2023
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
+ Coverage 88.80% 89.33% +0.52%
==========================================
Files 112 112
Lines 88282 90866 +2584
Branches 88282 90866 +2584
==========================================
+ Hits 78397 81171 +2774
+ Misses 7636 7455 -181
+ Partials 2249 2240 -9
☔ View full report in Codecov by Sentry. |
jkczyz
previously approved these changes
Oct 21, 2023
In 26c1639 we switched to using `Default::default()` to initialize `()` for scoring parameters in tests. A number of `()`s slipped back in recently, which we replace here.
... by passing an owned `String`, rather than taking an `&str` and `to_owned()`ing it.
... and correct direction which causes force-closure in another sentence.
Rather than only building with the `c_bindings` flag in certain crates, we go ahead and test all crates with the flag in CI here.
TheBlueMatt
force-pushed
the
2023-10-various-followups
branch
from
0144138 to
88af8a2
Compare
|
Ended up with a few more changes for bindings, so went ahead and addressed @jkczyz's feedback (and squashed those changes down). |
Because the bindings changes now require further changes to our type definitions, avoiding building the `Simple*` type aliases entirely makes the patchset there simpler.
TheBlueMatt
force-pushed
the
2023-10-various-followups
branch
from
88af8a2 to
4443db6
Compare
benthecarman
approved these changes
Oct 21, 2023
wpaulino
previously approved these changes
Oct 23, 2023
Because we can't map move semantics in most languages, we also can't map our current builders. Thus, we have to mark them no-export.
wpaulino
approved these changes
Oct 23, 2023
jkczyz
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.